Refine useAnimations feature #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bobbing animation with S2C network interaction. * unregister mixin - `mixin.common.features.useAnimations.ItemStackMixin` * new files - `client.features.useAnimatins.AnimationsHelper` - `mixin.client.features.useAnimations.ClientPlayerEntityMixin` - `mixin.client.features.useAnimations.ClientPlayerInteractionManagerMixin` - `mixin.client.features.useAnimations.ClientPlayNetworkHandlerMixin`
* update `AnimationsHelper.java` - new constant `COOLDOWN_TIME_MILLIS` based on Minecraft tick millis - new fields `lastBobbingStack` and `lastBobbingTime` - check the animated stack and the currentTimeMillis * new files - `mixin.client.features.useAnimations.MinecraftClientAccessor` - `mixin.client.features.useAnimations.RenderTickCounterAccessor` * some minor fixes
* not only for BoneMeal
* constant has changed - `COOLDOWN_TIME_MILLIS` is now half of `ANIMATION_TIME` * tickTimeMillis
* boolean `pickupAnimations` has moved - BedrockifySettings#pickupAnimations -> BedrockifyClientSettings#pickupAnimations
lonefelidae16
commented
Jan 4, 2023
src/main/java/me/juancarloscp52/bedrockify/client/features/useAnimations/AnimationsHelper.java
Outdated
Show resolved
Hide resolved
This reverts commit 88f4949.
|
I will end my commit with this comment for now. Works fine for me (and I enjoying on my server), but there are still issues:
Sorry for the many commits. If I should squash these, it doesn’t matter to combine them into a reasonable amount of granularity. But please note, it needs to FORCE push with Please let me know if you have any further suggestions. |
|
Hey! Sorry for the late response. I'll be testing this implementation and its differences with the previous one this week |
|
Thank you! Whenever you’re ready. |
|
Looks good! I think that the remaining issues are not as noticeable, and is a comprehensible compromise for having item animations client-side. Thank you. |
This was referenced Mar 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #206
Bobbing animation with S2C network interaction.
It also works when played on a vanilla server.
Known issues
Non-mining tools such as “Flint and Steel” are always animated when destroying a block using it.Solved.
Using Bone Meal will cause double-bobbing due toClientPlayerInteractionManager#interactItemreturnsActionResult.SUCCESSand decreasing in stack.edit: Solved in commit: c2395f6 and da10b9d.
LivingEntityand handle it inClientPlayerEntity, but this solution doesn’t work on a vanilla server. Also, there may be a conflict in the magic number of the statuses in a future update.