[refactor] reacharound placement feature #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the feature of ReachAround placement. Shorter lines, more maintenability.
also resolve #211
Checklists
Compatibility
Block placement
Changes
update
ReachAroundPlacement.java
isNonFullBlock
, useEntity#getSteppingPos
insteadcheckReachAroundAndExecute
, due to injection method has changedcanReachAround
: private -> publiccanReachAround
:Entity#isOnGround
instead of checking theBlockState
Entity#getSteppingPos
instead ofBlockPos#down
to avoid collision errorupdate
MinecraftClientMixin.java
MinecraftClient.crosshairTarget
instead of executing the unique methodcheckReachAroundAndExecute