-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Bedrock Sun Glare and Sky Color #224
Merged
juancarloscp52
merged 6 commits into
juancarloscp52:1.19.3
from
lonefelidae16:feat/sun-glare
Feb 25, 2023
Merged
[feat] Bedrock Sun Glare and Sky Color #224
juancarloscp52
merged 6 commits into
juancarloscp52:1.19.3
from
lonefelidae16:feat/sun-glare
Feb 25, 2023
Commits on Feb 9, 2023
-
[feat] Bedrock Sun Glare and Sky Color
The feature of Bedrock Sun Glare and Sky Color. This is enabled by the `sunlightIntensity` value and `bedrockShading` option in the Visual Improvements settings. * new configurable parameters - int `BedrockifyClientSettings#sunlightIntensity`: 0 - 100, default 50 * update `lang/en_us.json` - edit `bedrockify.options.bedrockShading` - add `bedrockify.options.sunlightIntensity` - add tooltip texts: + `bedrockify.options.bedrockShading.tooltip` + `bedrockify.options.sunlightIntensity.tooltip` * update `BedrockifyClientSettings` - add a field `sunlightIntensity` * update `SettingsGUI` - add tooltip for the options: + `bedrockShading` + `sunlightIntensity` * registered new mixins - `mixin.client.features.bedrockShading.sunGlare.ClientWorldMixin` + to modify the Sky color - `mixin.client.features.bedrockShading.sunGlare.WorldRendererMixin` + to modify the Sun radius * moved mixins - `mixin.client.features.bedrockShading.AbstractQuadRendererMixin` -> `lightBlock.AbstractQuadRendererMixin` - `mixin.client.features.bedrockShading.BlockModelRendererMixin` -> `lightBlock.BlockModelRendererMixin` - `mixin.client.features.bedrockShading.FluidRendererMixin` -> `lightBlock.FluidRendererMixin` * new files - `client.features.bedrockShading.BedrockSunGlareShading` + helper class that calculate angle diff
Configuration menu - View commit details
-
Copy full SHA for 86cf6d6 - Browse repository at this point
Copy the full SHA 86cf6d6View commit details -
Make it compatible with shader mods. * update `BedrockSunGlareShading` - inner classes: + enum `ShaderState`: shows the state of custom shader + class `ClassMethodHolder`: holds class name, method name, args and predicate - fields: + ShaderState `shaderState`: to determine the state of custom shader + Map `MOD_ID_CLASS_MAP`: uses with Reflection - methods: + void `reloadCustomShaderState`: notifies changed the shader state + boolean `isEnabled` -> `shouldApplyShading`: gets whether can apply this feature + ShaderState `fetchShaderStateInternal`: gets the state of custom shader * update `mixin.client.features.bedrockShading.sunGlare.WorldRendererMixin` - new method `bedrockify$reloadWorldRendererCallback`: to reload the state of custom shader
Configuration menu - View commit details
-
Copy full SHA for 9f6d0ea - Browse repository at this point
Copy the full SHA 9f6d0eaView commit details -
Adds a test case to be compatible with Iris shaders using Reflection. * update dependencies - `build.gradle` + fabric loom 1.1-SNAPSHOT + add a sourceSet of the test + add Modrinth's maven repo + add Iris, JUnit - `gradle.properties` + add a property of Iris version * new files - `test.client.features.bedrockShading.sunGlare.IrisCompatTest` + > ./gradlew test
Configuration menu - View commit details
-
Copy full SHA for 36f8377 - Browse repository at this point
Copy the full SHA 36f8377View commit details
Commits on Feb 13, 2023
-
[optimize] calculating the dot product
Update the sun vector after client tick due to the sun does not move so fast. Update the dot product only once when executed `WorldRenderer#renderSky`. * update `BedrockSunGlareShading` - fields: + float `sunAngleDiff` + Vector3f `sunVector3f` + MinecraftClient `client` - methods: + void `tick` + void `updateAngleDiff` + static float `getSunAngleDiffClamped(float)` -> float `getSunAngleDiff()` * update `BedrockifyClient` - register a new method in `END_CLIENT_TICK`: + `BedrockSunGlareShading#tick` * update `WorldRendererMixin` - method name has changed: `bedrockify$storeSunAngleDiff` -> `bedrockify$updateSunAngleDiff` - mixin injection point has changed: `HEAD` -> `BEFORE_INVOKE` target = `ClientWorld#getSkyColor`
Configuration menu - View commit details
-
Copy full SHA for 3a2da3c - Browse repository at this point
Copy the full SHA 3a2da3cView commit details -
* update `en_us.json` - the word "vanilla rendering" might not be user friendly * update `IrisCompatTest.java` - add JavaDoc - add affected class info to error message * update `BedrockSunGlareShading.java` - update JavaDoc - add new const: ClassMethodHolder `ClassMethodHolder#CONDITION_TRUE` * update `ClientWorldMixin.java` - does not require to extend super class
Configuration menu - View commit details
-
Copy full SHA for 9e7c85b - Browse repository at this point
Copy the full SHA 9e7c85bView commit details
Commits on Feb 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2de4526 - Browse repository at this point
Copy the full SHA 2de4526View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.