[fix] behavior of the Cauldrons #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Breaking changes to your existing world!** This allows to create Tipped Arrows with Potion Cauldron. The maximum level of Potion Cauldron become 8. If it exists in your world, the fluid level will be lower. To avoid this error, please take these out. * update `BedrockCauldronBehavior` - add `TIPPED_ARROW_WITH_POTION` behavior * update `AbstractBECauldronBlock` - now extends `AbstractCauldronBlock` * unregistered mixins - `mixin.common.features.cauldron.AbstractCauldronBlockMixin` - `mixin.common.features.cauldron.LeveledCauldronBlockAccessor` * new block models without using `LeveledCauldronBlock`
**Breaking changes to your existing world!** This allows following: * Stain the item 6 times * Mix already colored water with different dyes The maximum level of Colored Water Cauldron become 6. If it exists in your world, the fluid level will be lower. The way of retaining color info has changed. Colored Water Cauldron may appear to be black water. To avoid this error, please take these out. * new file `ColorBlenderHelper` - the method of `blendColors` is inspired by `DyeableItem#blendAndSetColor` * update `BedrockCauldronBehavior` - change the behavior * update `ColoredWaterCauldronBlock` - maximum level become 6 * update `WaterCauldronBlockEntity` - blend the color * new block models without using `LeveledCauldronBlock`
* update `BedrockIfyMixinPlugin` - cannot launch on DedicatedServer * update `BedrockCauldronProperties` - property name `level` will conflict with vanilla's cauldron
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for any inconvenience caused by my lack of attention. Please wait a moment while I run the final check... Looks good.
fix #252 , resolve #176
Important: This is the Breaking Changes to the existing world.
This allows following:
Breaks
The maximum level of Potion Cauldron become 8, and Colored Water Cauldron become 6. If they exist in your world, the fluid level will be lower.
The way of retaining color information has changed. The Water Cauldron which is dyed may appear to be black water.
To avoid these errors, please empty the cauldron before installing the new version.
Known Issues
The Bedrock’s cauldron behaves as follows:
Can wash the dye off 6 times of Leather Armors, Shulker Boxes, and top layer of Banners
When there is water fluid directly above the cauldron, it fills with water
These behavior still cannot be reproduced.
Changes
new file
ColorBlenderHelperblendColorsis inspired byDyeableItem#blendAndSetColorupdate files
AbstractBECauldronBlock: now extendsAbstractCauldronBlockBedrockCauldronBehavior: addTIPPED_ARROW_WITH_POTIONbehaviorWaterCauldronBlockEntity: now can blend two or more colorsColoredWaterCauldronBlock,PotionCauldronBlock: add more helper methodunregistered mixins
mixin.common.features.cauldron.AbstractCauldronBlockMixinmixin.common.features.cauldron.LeveledCauldronBlockAccessorseveral number of new block models without using
LeveledCauldronBlock