[fix] SlotHighlight #288
Merged
[fix] SlotHighlight #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update `slotHighlight.HandledScreenMixin` - method injection point has changed: `drawSlotHighlight` -> `drawSlot` - supports opacity
juancarloscp52
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #285
This also supports highlight opacity.
I remember an issue that it’d be nice to be able to see the slot background, and now it’s possible. But there are some limitations; the blending functionality is based on its alpha and sprite, so it needs to calculate backwards from the target color. In some cases, there are colors that cannot be produced.
This figure shows the case where the color of Item Slot Highlight Foreground is
#8955ba00:Note that resourcepacks and/or mods can easily change the sprites and it’s difficult to get the color you want.
Changes
slotHighlight.HandledScreenMixindrawSlotHighlight->drawSlotdrawSlot(DrawContext, Slot),focusedSlotisPointOverSlot(Slot, double, double),x,y