Add sync errorgroup handling in integration tests #1460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
force-pushed
the
kev-the-dev/integration-test-error-handeling
branch
from
3047fe4
to
39accdc
Compare
|
will wait to rebase and advance until after the reorg #1473 |
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Aug 29, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Aug 29, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Aug 29, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Aug 29, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Aug 29, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Aug 29, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Aug 29, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Aug 29, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Sep 2, 2023
Thanks @kev-the-dev Closes juanfont#1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
that referenced
this pull request
Sep 5, 2023
Thanks @kev-the-dev Closes #1460 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address TODOs in integration tests to handle errors from sync WaitGroup for things like bringing up a bunch of tailscale nodes. I ran into some confusing segfaults when running integration tests locally that would be helped by implementing this fail-on-error rather than log-on-error.
Closes #1459