Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance pipeline stability and automatically retry unstable tests #1566

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

vsychov
Copy link
Contributor

@vsychov vsychov commented Sep 28, 2023

Hello there,

This Pull Request aims to introduce changes designed to enhance the overall stability of the pipeline and implement an automatic retry mechanism for tests that are currently unstable.

There is example, pipeline with retry: vsychov#2
There is pipeline without retry: #1562

Both of them contains same headscale file changes.

Another way to do that, is use --rerun-fails and --rerun-fails-max-failures arguments of gotestsum.

@vsychov
Copy link
Contributor Author

vsychov commented Sep 28, 2023

@kradalby, can you take a look?

@kradalby
Copy link
Collaborator

Apologise, missed this one, I had it in my todo list to do something like this, but I think 50 is a bit excessive, how about we start with 5.

The goal needs to be to get the tests to a state where that (or less) is the upper threshold.

@vsychov
Copy link
Contributor Author

vsychov commented Nov 27, 2023

@kradalby , done, I changed it to 5.

Comment on lines +62 to +64
with:
attempt_limit: 5
command: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this removes a bit too much?

Suggested change
with:
attempt_limit: 5
command: |
with:
attempt_limit: 5
command: |
nix develop --command -- docker run \

Copy link
Contributor Author

@vsychov vsychov Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry for that, I didn't check the changes after rebasing to main, now it's fixed.

@kradalby kradalby merged commit 85e92db into juanfont:main Nov 27, 2023
31 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants