✨ feat: add pqsql configs for open and idle connections #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallabpain
force-pushed
the
fix/postgres-connections
branch
from
6bca167
to
9274087
Compare
kradalby
reviewed
Jan 16, 2024
pallabpain
force-pushed
the
fix/postgres-connections
branch
3 times, most recently
from
447eb2f
to
551c460
Compare
kradalby
reviewed
Jan 18, 2024
pallabpain
changed the title
|
Sorry for the delay, this should be up and running |
pallabpain
force-pushed
the
fix/postgres-connections
branch
from
551c460
to
91bb85e
Compare
@kradalby Thank you. I've updated the PR. I may have also run |
pallabpain
changed the title
pallabpain
changed the title
When Postgres is used as the backing database for headscale, it does not set a limit on maximum open and idle connections which leads to hundreds of open connections to the Postgres server. This commit introduces the configuration variables to set those values and also sets default while opening a new postgres connection.
pallabpain
force-pushed
the
fix/postgres-connections
branch
from
f39ab09
to
c052d6c
Compare
kradalby
approved these changes
Feb 9, 2024
|
@pallabpain does that mean headscale is now usable with postgres? |
@SuperSandro2000 It was already usable with Postgres. It now makes use of connection pooling as well. |
|
I constantly ran into #1584 which rendered headscale completely broken for me. It's that issue now fixed and can be closed? |
|
Yes, that should be resolved with this fix. In order to mitigate the issue with a previous stable version of headscale, you can consider running PGBouncer. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Postgres is used as the backing database for headscale, it does not set a limit on maximum open and idle connections which leads to hundreds of open connections to the Postgres server. This commit fixes that by setting up a connection pool while creating the gorm DB instance.
Depends