Add assert func for verifying status, netmap and netcheck #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
commented
Feb 8, 2024
| @@ -190,9 +190,15 @@ func (h *Headscale) handlePoll( | |||
| return | |||
| } | |||
|
|
|||
| // TODO(kradalby): Figure out why patch changes does | |||
There was a problem hiding this comment.
I will work on this in a follow up so it doesnt become even bigger.
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
assert-status-netmap
branch
from
20cfb96
to
7db863e
Compare
juanfont
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new integration test assert methods which will do the following for the "general" case:
assertValidNetmap: in clients which supporttailscale debug netmapit will dump the netmap and verify that it is in a known "good" state, this includes checking for endpoints, derp relays, ips, online status and more.assertValidStatus: check the output of thetailscale statuscommand, checking derp relay, hostname, os, peer ips, network map status and magic sock statusassertValidNetcheck: checks that the client has a valid DERP server using output fromtailscale netcheck.The "general" case is any all to all communication, it does not account for things like nodes with ACLs and similar.
This also splits "PingAllByAll" into two, one version which use internal DERP for better use offline or dodgy internet, and one with public DERP.
Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com