Update DERP server definitions #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I didn't actually include all official Tailscale DERP servers because people should be running their own DERP infra. But it does not make sense to just include some of them... The fields you are mentioning are just part of the DERPNode struct https://github.com/tailscale/tailscale/blob/main/tailcfg/derpmap.go#L87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo link referenced in derp.yaml is invalid and is missing the new DERP addresses.
This PR updates the file to use the newest tailscale DERP servers and updates the link in the comment.
Out of curiousity is
stunonlyalwaysfalse, andderptestportalways0?stunport,stunonly, andderptestporthave no references in the code so not sure if these fields are still needed.