Topic/docker release #89
Conversation
.github/workflows/release.yml
Outdated
| # list of Docker images to use as base name for tags | ||
| images: | | ||
| ${{ secrets.DOCKERHUB_USERNAME }}/headsacle |
There was a problem hiding this comment.
Is this a generic variable that will resolve to juanfont? Or will this set it up to release under your name?
There was a problem hiding this comment.
Sorry just saw the issue, it will resolve to the headscale user on dockerhub from my understanding?
And then follow the repo on GitHub?
There was a problem hiding this comment.
| ${{ secrets.DOCKERHUB_USERNAME }}/headsacle | |
| ${{ secrets.DOCKERHUB_USERNAME }}/headscale |
There was a problem hiding this comment.
The DOCKERHUB_USERNAME can be anything we would like to. My suggestion would be headscale/headscale as mentioned in the issue. So the DOCKERHUB_USERNAME would be in that case also headscale
There was a problem hiding this comment.
Cool, sounds reasonable, I was mostly seeking continuity/integrity by either using headscale or juanfont so people understand its the official image.
Does this need @juanfont to add a secret before merging?
There was a problem hiding this comment.
Yeah @juanfont would have to add secrets to the repo first. (I also would hand over the dockerhub account to him) Maybe we can also think about moving the project into an organization. Probably we should discuss that.
There was a problem hiding this comment.
Maybe we can also think about moving the project into an organization. Probably we should discuss that.
I suppose this can be created as a issue for discussion, I personally dont see any reason and I believe having it like this gives @juanfont the appropriate credit for implementing the project.
There was a problem hiding this comment.
Yeah that is a good idea to move it to a separate issue.
|
Should this PR Update the readme with the appropriate urls and information to make it apparent to the end user? |
|
Small typo on dockerhub? -> ohdearaugustin/headsacle |
Fix typo Co-authored-by: Kristoffer Dalby <kradalby@kradalby.no>
I will add some infos to the readme. |
|
Hey, Apologies for the delay. I was a bit on holidays :) @ohdearaugustin have you registered https://hub.docker.com/u/headscale ? |
|
@juanfont yeah I would have registered that account. I can hand it over to you. |
|
What is the state for this PR? |
|
@ohdearaugustin could you please send me the creds to juanfontalonso@gmail.com ? Apologies for the delay! |
|
@juanfont you got a mail. Added some docu. |
|
Fantastic! Merged! |
Closes #88
To see the PR in action you can take look at following links. As I already tested it.
github (ghrc):
https://github.com/ohdearaugustin/headscale
docker hub:
https://hub.docker.com/r/ohdearaugustin/headsacle/tags?page=1&ordering=last_updated