Make AuthorizationBackend and Client more easily adjustable #278
Labels
Comments
kerrermanisNL
pushed a commit
to ByteInternet/django-oidc-provider
that referenced
this issue
Sep 14, 2018
To make it easier to change the AuthorizeEndpoint and Client we set them as class variables. Then people inheriting from the view are able to easily change them. In my personal case this helps with skipping consent more explicitly as defined in issue juanifioren#278
|
Hm, I just realised that seeing it in the admin is probably explicit enough. Kind of a fail on my part 😏 I still think the PR could prove useful though. I'll let you guys decide what to do with it. |
|
I think per-client edition on admin is quite good for the moment. Also that the logic should be on Client model (not another one). Thanks @kerrermanisNL |
|
Yeah I agree. Somehow the admin stuff just hadn't occurred to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previously PR #163 removed the settings for skipping consent. Instead the functionality was moved to the
Clientmodel, but it's quite hard to make changes to make sure customClientsare used. So it would be nice to introduce some functionality that would improve this. I know it would be possible to make the change on the actualCliententry in the database, but this is obscure and not easily visible for other developers. I'd rather have some explicit model define this change instead.PR incoming that should make this stuff a little easier to manage.
The text was updated successfully, but these errors were encountered: