Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect id_token generation when using OIDC_IDTOKEN_INCLUDE_CLAIMS and OIDC_EXTRA_SCOPE_CLAIMS at the same time #285

Closed
ellmetha opened this issue Sep 28, 2018 · 1 comment
Labels

Comments

@ellmetha
Copy link
Contributor

The problem appears when using the OIDC_IDTOKEN_INCLUDE_CLAIMS and OIDC_EXTRA_SCOPE_CLAIMS settings at the same time. In that case the generated id_token contains only the claims associated with the OIDC_EXTRA_SCOPE_CLAIMS setting (and not the standard claims that could've been requested during the authentication flow). The problem seems to be related with this section of the codebase.

ellmetha added a commit to impak-finance/django-oidc-provider that referenced this issue Sep 28, 2018
…ed at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting
juanifioren added a commit that referenced this issue Sep 29, 2018
Fixed #285 -- Ensured standard and custom claims can be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting
@juanifioren
Copy link
Owner

Nice. Thanks!

juanifioren added a commit that referenced this issue Sep 29, 2018
…at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting"
juanifioren added a commit that referenced this issue Sep 29, 2018
Revert "Fixed #285 -- Ensured standard and custom claims can be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting"
juanifioren added a commit that referenced this issue Sep 29, 2018
Fixed #285 -- Ensured standard and custom claims can be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting
bpereto pushed a commit to bpereto/django-oidc-provider that referenced this issue Dec 3, 2018
…an be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting"
zvyn pushed a commit to zvyn/django-oidc-provider that referenced this issue May 25, 2019
…an be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting"
zacps pushed a commit to catalyst/django-oidc-provider that referenced this issue Jan 16, 2020
…an be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting"
rhysmdnz pushed a commit to rhysmdnz/django-oidc-provider that referenced this issue Feb 4, 2020
…ed at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting
adamlynam-catalyst pushed a commit to catalyst/django-oidc-provider that referenced this issue Mar 5, 2020
…an be used at the same time when using the OIDC_IDTOKEN_INCLUDE_CLAIMS setting"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants