Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust schema to the strict mode #297

Merged

Conversation

batovpasha
Copy link
Contributor

Adjust schema to the strict mode that is enabled by default since AJV v7.

@juanjoDiaz
Copy link
Owner

Good stuff.
This are actually issues also in v2 (the properties one I already fixed it there 😅).

Can you please target master instead of v3?
Once serverless 3 is released, I'll rebase the v3 branch on top of master.

@batovpasha batovpasha changed the base branch from serverless_v3 to master January 21, 2022 09:34
@batovpasha
Copy link
Contributor Author

@juanjoDiaz Good, I changed the target branch.

@juanjoDiaz
Copy link
Owner

Thanks!

You've brought to this PR all the changes in the v3 branch.
Can you reset this branch to master and cherry pick the fix: adjust schema to the strict mode commit so just that one commit gets in?

Sorry for the confusion!

@batovpasha
Copy link
Contributor Author

@juanjoDiaz Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants