Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating a CloudWatch log, not deleted in "sls remove". #57

Closed
cdichiara opened this issue Mar 8, 2018 · 11 comments
Closed

Generating a CloudWatch log, not deleted in "sls remove". #57

cdichiara opened this issue Mar 8, 2018 · 11 comments

Comments

@cdichiara
Copy link

Hi, nice plugin. :)

I believe you're generating a CloudWatch log "--warmup", but it's not registered with the CloudFormation stack, so when you uninstall the deployment it persists and interferes with redeployment, I think.

@alvarodms
Copy link

I'm also having issues with redeployment.

Getting the following error:

Serverless: Updating Stack...
Serverless: Checking Stack update progress...
........
Serverless: Operation failed!

  Serverless Error ---------------------------------------

  An error occurred: WarmUpPluginLogGroup - /aws/lambda/test-api-warmup-plugin already exists.

I had to manually delete that log group on CloudWatch.

@goncaloneves
Copy link
Contributor

goncaloneves commented Apr 9, 2018

@cdichiara @alvarodms What version were you using, 3.6.0?

@goncaloneves
Copy link
Contributor

goncaloneves commented Apr 9, 2018

It should have been the options bug from 3.6.0. Did a quick double deploy / remove test and it's working fine with latest 3.6.1 version.

Warmup log group is created and removed properly.

(edit)
Closing. If error persists, let us know here.

@cdichiara
Copy link
Author

Oh, thanks, I just updated - I was way back at 3.3.0, that's probably it.

@sashokbg
Copy link

sashokbg commented Mar 6, 2019

I am experiencing this problem with 3.6.2-rc.1 any advise ?

@juanjoDiaz
Copy link
Owner

Any reason to not update to the latest version 4.4.3-rc.1?

@antoniuslin
Copy link

Serverless Error ---------------------------------------

  An error occurred: WarmUpPluginLogGroup - /aws/lambda/lambda-warmer already exists in stack arn:aws:cloudformation:us-e...

Bump.
Hello. I'm still experiencing this issue using "serverless-plugin-warmup": "^4.5.3-rc.1",. I encountered the issue during a re-deploy. Is there a plan on the way?
Thank you.

@juanjoDiaz
Copy link
Owner

Hi @antoniuslin,

quick googling shows me that this is a known problem of Serverless when using multiple stages (serverless/serverless#5057)
Can you take a look at that and let me know if it helps?

@antoniuslin
Copy link

Hi @juanjoDiaz,

I can confirm that multiple stages of deployment. My issue seems to have disappeared (resolved?) when specifying the service & stage in the lambda warmer config block itself as you hinted from the link. E.g.

  warmup:
    enabled: true
    ...
    # specified
    name: ${self:service}-${opt:stage}-lambda-warmer
    # instead of the prior
    # name: 'lambda-warmer'
    ...
    timeout: 60

It resulted in a unique lambda log group per stage for the service.
Thanks much!

@juanjoDiaz
Copy link
Owner

That's odd since that should be the default name anyway.
And the name lambda-warmer is nowhere in the codebase.
Any idea of where was it coming from?

@antoniuslin
Copy link

Honestly, I don't remember and I'd just sooner chalk it up to my not RTFM & hasty copypasta from some article about this nice & nifty plugin somewhere. If I had just spent a couple of proper minutes reading the README.md, I would've found the info:

name (default ${service}-${stage}-warmup-plugin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants