Cyntia zavala #3
Conversation
cyntiazp
requested review from
agvaldezc,
a user and
juanjoms
and removed request for
a user
juanjoms
force-pushed
the
cyntia-zavala
branch
2 times, most recently
from
c79d32d
to
0b87f25
Compare
| }; | ||
| agregar(newFramework); | ||
| } | ||
| let agregar = (framework) => { |
There was a problem hiding this comment.
Parameters should always have a type, Typescript only infers a type when a variable is declared and assigned, so if we don't specify the type on parameters, the type will be any.
| button.disabled = false; | ||
| } | ||
| } | ||
| let save = () => { |
There was a problem hiding this comment.
When a variable or method is not going to be reassigned, is a better practice to use const instead of let.
| newUrl.value = ''; | ||
| button.disabled = false; | ||
| } | ||
| const list: HTMLElement = document.getElementById('list-tab'); |
There was a problem hiding this comment.
Although javascript uses Hoisting, it is a better practice to declare variables before using them (in this case list is used on line 71 but declared on line 77).
| <form id="new-frameworkjs" class="row"> | ||
| <div class="form-group col-3"> | ||
| <label for="newName">Nombre</label> | ||
| <input type="text" class="form-control" id="newName" value="" placeholder="Nombre" required> |
There was a problem hiding this comment.
For ids and class names its a better practice to separate words by a hypen i.e. id="new-name"
https://google.github.io/styleguide/htmlcssguide.html#ID_and_Class_Name_Delimiters
No description provided.