Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wendy rdz #7

Open
wants to merge 3 commits into
base: wendy-rdz-review
Choose a base branch
from
Open

Wendy rdz #7

wants to merge 3 commits into from

Conversation

WendyRdz
Copy link
Collaborator

No description provided.

</div>
<form class="form-inline" autocomplete="off">
<label class="sr-only" for="inlineFormInputTecnologia">Tecnologia</label>
<input type="text" class="formTecnologia form-control" id="inlineFormInputTecnologia" placeholder="Tecnologia">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ids and class names its a better practice to separate words by a hypen i.e. class="form-tecnologia" and id="inline-form-input-tecnologia":
https://google.github.io/styleguide/htmlcssguide.html#ID_and_Class_Name_Delimiters

} */

//inputs
const add:HTMLInputElement = document.getElementById('btnAdd') as HTMLInputElement;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be HTMLButtonElement

}


}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated end curly bracket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants