-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elia lara #8
base: elia-lara-review
Are you sure you want to change the base?
Elia lara #8
Conversation
|
||
|
||
|
||
let newFramework = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a variable or method is not going to be reassigned, is a better practice to use const
instead of let
.
|
||
let nombreK: HTMLInputElement= document.querySelector("#inlineFormInputName2"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused variable declarations
<div class="row"> | ||
<div class="col-3"> | ||
<label class="sr-only" for="inlineFormInputName2">Name</label> | ||
<input type="text" class="form-control mb-2 mr-sm-2" id="inlineFormInputName2" placeholder="Name"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ids and class names its a better practice to separate words by a hypen i.e. id="inline-form-input-name"
:
https://google.github.io/styleguide/htmlcssguide.html#ID_and_Class_Name_Delimiters
No description provided.