Skip to content

Commit

Permalink
OVN: Fix master control plane job name
Browse files Browse the repository at this point in the history
With PR openshift#778 (commit 518118b) we changed the service monitor definition,
and the daemonset serviceaccount.

With this PR we fix the serverName in the serviceMonitors, the
serviceAccount permissions and the prometheusRule alert expression.
  • Loading branch information
Juan-Luis de Sousa-Valadas Castaño committed Oct 5, 2020
1 parent af1f2ed commit 3255699
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 54 deletions.
6 changes: 6 additions & 0 deletions bindata/network/ovn-kubernetes/002-rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ rules:
- get
- list
- watch
- apiGroups: ['authentication.k8s.io']
resources: ['tokenreviews']
verbs: ['create']
- apiGroups: ['authorization.k8s.io']
resources: ['subjectaccessreviews']
verbs: ['create']

---
apiVersion: rbac.authorization.k8s.io/v1
Expand Down
57 changes: 6 additions & 51 deletions bindata/network/ovn-kubernetes/003-rbac-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ rules:
- get
- list
- watch
- apiGroups: ['authentication.k8s.io']
resources: ['tokenreviews']
verbs: ['create']
- apiGroups: ['authorization.k8s.io']
resources: ['subjectaccessreviews']
verbs: ['create']


---
Expand Down Expand Up @@ -133,54 +139,3 @@ subjects:
- kind: ServiceAccount
name: ovn-kubernetes-controller
namespace: openshift-ovn-kubernetes

---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: openshift-ovn-kubernetes-metrics
rules:
- apiGroups: [""]
resources:
- namespaces
- endpoints
- services
- pods
verbs:
- get
- list
- watch
- apiGroups: [""]
resources:
- events
verbs:
- create
- patch
- update
- apiGroups: ['authentication.k8s.io']
resources: ['tokenreviews']
verbs: ['create']
- apiGroups: ['authorization.k8s.io']
resources: ['subjectaccessreviews']
verbs: ['create']

---
apiVersion: v1
kind: ServiceAccount
metadata:
name: openshift-ovn-kubernetes-metrics
namespace: openshift-ovn-kubernetes

---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: openshift-ovn-kubernetes-metrics
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: openshift-ovn-kubernetes-metrics
subjects:
- kind: ServiceAccount
name: openshift-ovn-kubernetes-metrics
namespace: openshift-ovn-kubernetes
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
message: |
There is no running ovn-kubernetes master
expr: |
absent(up{job="ovnkube-master-metrics", namespace="openshift-ovn-kubernetes"} == 1)
absent(up{job="ovnkube-master", namespace="openshift-ovn-kubernetes"} == 1)
for: 10m
labels:
severity: warning
Expand Down
4 changes: 2 additions & 2 deletions bindata/network/ovn-kubernetes/monitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
scheme: https
tlsConfig:
caFile: /etc/prometheus/configmaps/serving-certs-ca-bundle/service-ca.crt
serverName: ovn-kubernetes-master-metrics.openshift-ovn-kubernetes.svc
serverName: ovn-kubernetes-master.openshift-ovn-kubernetes.svc
jobLabel: app
namespaceSelector:
matchNames:
Expand Down Expand Up @@ -65,7 +65,7 @@ spec:
scheme: https
tlsConfig:
caFile: /etc/prometheus/configmaps/serving-certs-ca-bundle/service-ca.crt
serverName: ovn-kubernetes-node-metrics.openshift-ovn-kubernetes.svc
serverName: ovn-kubernetes-node.openshift-ovn-kubernetes.svc
jobLabel: app
namespaceSelector:
matchNames:
Expand Down

0 comments on commit 3255699

Please sign in to comment.