-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added European Tracks #23
Added European Tracks #23
Conversation
This PR adds six circuits. Track limits (left and right) have been constructed with Google Earth and exported to kml files (included). Both kml are post processed using fastest-lap Python command: fastest_lap.circuit_preprocessor(options) to produce a single .xml file included. Tracks: - Hungaroring - Jarama - Pau ville (city track) - Vallelunga - Varano - Zolder
Hello! Could you also attach this notebook applied to the tracks you sent? I want to set this as a requisite to collaborators uploading their tracks, but I have forgot to add it to Contributing.md. If it is very inconvenient given the amount of tracks you have submitted, can you at least do it for pau_ville, vallelunga, and zolder? They seem to have large errors, though I am aware that the error measure is wrong for some tracks and the issue might be on my side. Thank you very much for your very nice contribution, Pierre |
I don't have Jupyter running but I can find all the i_start and i_end for every corner and add all the plot commands in a circuit_preprocessor.ipynb. Would that be good? You say the tracks have errors, what kind of error? What should I look for when plotting the tracks? |
In each of the XML files produced there's a header with this information <header>
<track_length units="m">3995.6606035603131</track_length>
<L2_error_left>3.746581096896739</L2_error_left>
<L2_error_right>1.9467386462668475</L2_error_right>
<max_error_left>84.101605320233034</max_error_left>
<max_error_right>61.549736514958695</max_error_right>
</header> This error is the distance between the approximation of the track through polynomials (what If you cannot install Jupyter notebook, it is good enough if you can give me the i_start and i_end in notebooks and then I can run them myself, as you mention. Please call these notebooks as the name of the track (e.g. Thanks a lot! Juan. |
Okay, understood. Is there a way to run the plots without generating the XML everytime? It's taking ages because of it. I tried just loading the track: And then calling the following line in the plotting function: This doesn't work (raises error) any idea why? (I checked path to track). Thanks |
Yes, the correct syntax is s = fastest_lap.load_track("../database/tracks/zolder/zolder.xml", track) ( |
I saw that load_track returns this value but in order to generate all the plots, I don't only need: |
Ah, I understood what happens. Yep, you cannot get them when loading from XML, it is not implemented. However, you need to rerun everytime? Can't you just open an interactive console and run circuit preprocessor once to get the data, and then just play with it? Sorry for the inconvenience. Will implement to download the rest of the variables soon. |
Yeah, that's how I've been doing it. I was just wondering if it was possible. |
Sorry again. I have opened an issue on this matter too. |
No worries, I understand that everything is still under construction. |
This PR adds one circuit. Track limits (left and right) have been constructed with Google Earth and exported to kml files (included). Both kml are post processed using fastest-lap Python command: fastest_lap.circuit_preprocessor(options) to produce a single .xml file included. Track: - Sachsenring Added Jupyter Notebooks for the following tracks: - Hungaroring - Jarama - Pau ville (city track) - Vallelunga - Varano - Zolder - Sachsenring
New commit with the Notebooks for all tracks + Sachsenring. Let me know if it's all okay. |
Amazing! Thank you very much Pierre |
This PR adds six tracks.
Track limits (left and right) have been constructed with Google Earth and exported to kml files (included). Both kml are post processed using fastest-lap Python command:
fastest_lap.circuit_preprocessor(options)
to produce a single .xml file included.
Tracks: