Fix sample rate issues #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmc2005
commented
Jun 5, 2023
| # Dynamic resampling if the audio source isn't compatible | ||
| if sample_rate != self.source.sample_rate: | ||
| msg = f"Audio source has sample rate {self.source.sample_rate}, " \ | ||
| f"but pipeline's is {sample_rate}. Will resample." | ||
| logging.warning(msg) | ||
| self.stream = self.stream.pipe( | ||
| ops.map(blocks.Resample(self.source.sample_rate, sample_rate)) | ||
| ops.map(blocks.Resample(self.source.sample_rate, sample_rate, self.pipeline.config.device)) |
There was a problem hiding this comment.
Resample before rearrange_audio_stream so the same audio is not resampled multiple times.
Because of how the first 5s buffer is filled at the beginning, this actually means that Resample will be called more times, but (unless it's running on GPU) each call should also be faster because the size of the chunk is reduced by 10 (80k vs 8k samples)
There was a problem hiding this comment.
Let's track this for a future PR, see #180
juanmc2005
force-pushed
the
fix/samplerate
branch
from
c878998
to
9fd258f
Compare
Merged
juanmc2005
added a commit
that referenced
this pull request
Oct 28, 2023
* Add automatic sample rate detection in MicrophoneAudioSource. Fix resampling crash. * Replace block_size by block_duration in audio source constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #152.
Changelog
MicrophoneAudioSourcenow detects supported sample rates and chooses the lowest possible one (higher than 16khz)MicrophoneAudioSourceno longer receives asample_rateargumentblock_sizeargument toblock_durationin all audio sourcesStreamingInferencewhen resampling audio to pipeline's sample rateResamplecan now run on GPU by passing adeviceargument