Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joss] Use ABC and abstractmethod rather than NotImplementedError (rebased) #179

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[joss] Use ABC and abstractmethod rather than NotImplementedError (rebased) #179

merged 1 commit into from
Oct 11, 2023

Conversation

juanmc2005
Copy link
Owner

Same as #173 but rebased on top of develop

@sneakers-the-rat posted:

NotImplementedError has slightly different semantics and effects than using ABC and abstractmethod - ABC classes can't be instantiated without satisfying all their abstractmethods, vs. raising an error which might not be obvious until the class is actually used. This also allows for static analysis tools to warn you when you haven't completed all the abstractmethods :)

part of: openjournals/joss-reviews#5266

@juanmc2005 juanmc2005 added the refactoring Internal design improvements that don't change the API label Oct 11, 2023
@juanmc2005 juanmc2005 added this to the Version 0.8 milestone Oct 11, 2023
@juanmc2005 juanmc2005 mentioned this pull request Oct 11, 2023
Closed
@juanmc2005 juanmc2005 merged commit fa4eecd into develop Oct 11, 2023
@juanmc2005 juanmc2005 deleted the abc branch October 11, 2023 14:03
@juanmc2005 juanmc2005 mentioned this pull request Oct 26, 2023
Merged
juanmc2005 added a commit that referenced this pull request Oct 28, 2023
@juanmc2005 @sneakers-the-rat
Replace NotImplementedError with ABC/abstractmethod (#179)
d43cacf 
Co-authored-by: sneakers-the-rat <JLSaunders987@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Internal design improvements that don't change the API
Projects
None yet
Milestone
Version 0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juanmc2005 @sneakers-the-rat