Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with torchaudio streams #91

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Compatibility with torchaudio streams #91

merged 3 commits into from
Sep 6, 2022

Conversation

juanmc2005
Copy link
Owner

@juanmc2005 juanmc2005 commented Sep 2, 2022 •
edited
Loading

This PR addresses issue #27.

Changelog

  • Add TorchStreamAudioSource to wrap torchaudio's StreamReader
  • Make all audio sources "irregular". They do not provide chunks in the format expected by the pipeline
    • This improves the flexibility of audio sources
    • is_regular() method has been removed
    • Only "regular" audio source is the (soon deprecated) PrecalculatedFeaturesAudioSource
  • OnlineSpeakerDiarization always formats the stream to the required chunk duration and step

@juanmc2005 juanmc2005 added feature New feature or request API Improvements to the API labels Sep 2, 2022
@juanmc2005 juanmc2005 added this to the Version 0.6 milestone Sep 2, 2022
@juanmc2005 juanmc2005 merged commit 014279e into develop Sep 6, 2022
@juanmc2005 juanmc2005 deleted the feat/streams branch September 6, 2022 12:56
@juanmc2005 juanmc2005 mentioned this pull request Sep 13, 2022
Closed
@juanmc2005 juanmc2005 mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Improvements to the API feature New feature or request
Projects
None yet
Milestone
Version 0.6
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@juanmc2005