Create addNAstr instead of overriding base::addNA

[juba]

The new addNA function (see #12) adds an interesting functionality, but I'm not sure it's a good way to implement it because :

• it overrides a base function, which I'm not very happy with
• this overriding generates a warning each time questionr is loaded
• it duplicates the code of the base function

So I wonder if it would not be better, instead of overriding and adding an argument to addNA, to create a new addNAstr function (or whatever better name we could find) which would be something like (not tested) :

addNAstr <- function(..., value=NULL) {
   x <- addNA(...)
   s <- ifelse(is.character(value), value, "NA")
   levels(x)[is.na(levels(x))] <- s
   x
}

What do you think ?

[larmarange]

Well. I'm ok with both options.

[juba]

In fact, I'm currently fighting with the fact that one of the imported package in questionr is overriding another base function (see #19), so I would be very inclined not to do it. But I'm not objective at all right now :-)

[larmarange]

Well you can change the name of the function. It's not a major concern for
me.

Joseph Larmarange
Le 7 nov. 2013 15:58, "Julien" notifications@github.com a écrit :

In fact, I'm currently fighting with the fact that one of the imported
package in questionr is overriding another base function (see #19#19),
so I would be very inclined not to do it. But I'm not objective at all
right now :-)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-27972105
.