Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused serialize function can be eliminated #742

Closed
suma opened this issue Apr 9, 2014 · 2 comments
Closed

Unused serialize function can be eliminated #742

suma opened this issue Apr 9, 2014 · 2 comments
Assignees
@suma
Labels
core refactoring
Milestone
0.6.0

Comments

@suma
Copy link
Member

suma commented Apr 9, 2014

some algorithms(e.g. storage) have serialize function but it seem to be unsed.

jubatus/jubatus/core/storage/bit_index_storage.hpp

Line 69 in f1fdcf0

void serialize(Ar& ar) {

@unnonouno
Copy link
Member

👍
I've found the same type of mistake. Do you have an idea to check the same problems?

@kmaehashi kmaehashi added this to the Near Future milestone Apr 14, 2014
@kmaehashi kmaehashi modified the milestones: Pending, Near Future May 7, 2014
@kmaehashi kmaehashi modified the milestones: 0.6.0, Pending May 7, 2014
@kmaehashi
Copy link
Member

Discussion from the meeting on 2014-05-17:

  • Removing such dead codes may slightly improve compilation time, but we think that it is not very cost effective.
  • As it is difficult to automatically detect dead codes, we'll remove as we find them.

suma added a commit that referenced this issue May 7, 2014
@suma
Eliminate unsed serialize: fixes #742
7fe3f3a
@suma suma closed this as completed May 7, 2014
suma added a commit that referenced this issue May 7, 2014
@suma
Eliminate unused serialize: fixes #742
b6357e7 
Conflicts:

	jubatus/core/framework/mixable.cpp
	jubatus/core/recommender/recommender_mock_storage.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suma suma

Labels
core refactoring
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
3 participants
@suma @unnonouno @kmaehashi