Prepare porting pficommon for Jubatus #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changed ported pficommon headers.
|
I think that pfi-config.h should be renamed. |
|
I renamed |
|
👍 |
suma
added a commit
that referenced
this pull request
Oct 7, 2013
Prepare porting pficommon for Jubatus
suma
added a commit
that referenced
this pull request
Oct 8, 2013
suma
added a commit
that referenced
this pull request
Nov 11, 2013
suma
added a commit
that referenced
this pull request
Nov 11, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create jubatus/util directory and ported pfi/pficommon module for Jubatus. We decided to port pficomon for Jubatus at the regular meeting.
This PR contains below instruction 1 to 3, and wscript modified for installing jubatus_util shared object and headers.
https://gist.github.com/suma/589470bcf50c5605960e (written in Japanese)
We need to remove pficommon dependency and to use ported jubatus_util when this PR merged.