(WIP) throw a exception on cluster methods if it comes before k-means runs #675

kumagi · 2014-02-18T08:43:00Z

This PR is correspond to #667

Some clustering RPC cause segfault before it runs clustering calculation.
We should check kcenters_ before access it.

suma · 2014-02-20T02:37:15Z

Test fails.

kumagi · 2014-02-20T02:41:52Z

@suma Sorry, I'll fix.

suma · 2014-02-20T05:30:28Z

Could you add unit test for this exception? (in driver or core?)

suma · 2014-02-20T05:40:48Z

jubatus/core/clustering/kmeans_clustering_method.hpp

@@ -25,6 +25,18 @@
 namespace clustering {

 class clustering_method_serializer;
+class no_cluster_exception : public std::exception {


Should we use jubatus_exception?

kumagi · 2014-02-21T09:19:50Z

I add test for exception.
But I don't know the behavior of gmm so I can't decide whether it should throw the exception.
I need someone's help.

kmaehashi · 2015-09-28T04:38:26Z

suma reviewed Feb 20, 2014
View reviewed changes

kmaehashi assigned unnonouno Feb 24, 2014

kmaehashi added improvement labels Feb 24, 2014

kmaehashi added this to the Near Future milestone Feb 25, 2014

KUMAZAKI Hiroki added 4 commits February 25, 2014 17:23

throw a exception on cluster methods if it comes before k-means runs

6b0fdf7

gmm::get_cluster: range check is needed

a9fb91b

not ed cluster's get_k_center should return vector with 0 length

89e8e5b

test: clustering throws exception

b214cda

kmaehashi assigned kmaehashi and unassigned unnonouno Jul 6, 2015

kmaehashi closed this Sep 28, 2015

kmaehashi removed this from the Near Future milestone Sep 28, 2015

Provide feedback