(WIP) throw a exception on cluster methods if it comes before k-means runs #675

Closed
wants to merge 4 commits into
from

4 participants

@kumagi
Jubatus member

This PR is correspond to #667

Some clustering RPC cause segfault before it runs clustering calculation.
We should check kcenters_ before access it.

@suma
Jubatus member

Test fails.

@kumagi
Jubatus member

@suma Sorry, I'll fix.

@suma
Jubatus member

Could you add unit test for this exception? (in driver or core?)

@suma suma commented on an outdated diff Feb 20, 2014
jubatus/core/clustering/kmeans_clustering_method.hpp
@@ -25,6 +25,18 @@
namespace clustering {
class clustering_method_serializer;
+class no_cluster_exception : public std::exception {
@suma
Jubatus member
suma added a line comment Feb 20, 2014

Should we use jubatus_exception?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@kumagi
Jubatus member

I add test for exception.
But I don't know the behavior of gmm so I can't decide whether it should throw the exception.
I need someone's help.

@unnonouno unnonouno was assigned by kmaehashi Feb 24, 2014
@kmaehashi kmaehashi added this to the Near Future milestone Feb 25, 2014
@kmaehashi kmaehashi assigned kmaehashi and unassigned unnonouno Jul 6, 2015
@kmaehashi
Jubatus member

This issue was fixed via jubatus/jubatus_core#151 and jubatus/jubatus_core#95.

@kmaehashi kmaehashi closed this Sep 28, 2015
@kmaehashi kmaehashi removed this from the Near Future milestone Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment