modified char_splitter to support UTF-8 (implements #299) #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (end == std::string::npos) { | ||
| size_t len = string.size() - begin; | ||
| bounds.push_back(std::make_pair(begin, len)); | ||
| size_t len_bytes = ustring_to_string(target.substr(begin, len)).size(); |
There was a problem hiding this comment.
I think this target.substr(begin, len) is equal to target.substr(begin) because this code get the substring of target from begin to the end of target.
And also the variable len is not necessary in this condition.
|
As a future work, we can speed-up this feature extraction by couting bytes of |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #299