Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add ability to daemonize fakes3 server. Fixes #109. #115

Closed
wants to merge 3 commits into from

Conversation

jchristi
Copy link

Adds a command line argument to allow daemonizing the server process.

@basicBrogrammer
Copy link

Yes please 👍

@pickhardt
Copy link
Collaborator

Hi @jchristi,

Thanks for the pull request!

Sorry for the delayed response. I really like this.

I can merge it in if you do two things first:

  1. Can you resolve the merge conflicts? I must've made some changes since you made the PR. Apologies for not reviewing this sooner. I took over as lead maintainer recently and am gradually making progress going over the old PRs and issues.

  2. We have a contributor license agreement (CLA) based off of Google and Apache's CLA. If you would feel comfortable contributing to, say, Angular.js, you should feel comfortable with this CLA.

Go here to sign the CLA: https://docs.google.com/forms/d/e/1FAIpQLSeKKSKNNz5ji1fd5bbu5RaGFbhD45zEaCnAjzBZPpzOaXQsvQ/viewform

Thanks a lot, and if you do those I promise I'll get to it sooner than last time!

@jchristi
Copy link
Author

jchristi commented Feb 8, 2017

Sorry, I do not support CLAs. That is a mistake for a small project like this and scares away potential contributors like me. If you change your mind about that requirement then I will consider re-submitting my patches.

@jchristi jchristi closed this Feb 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants