Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Rack #7

Closed
wants to merge 2 commits into from
Closed

Rack #7

wants to merge 2 commits into from

Conversation

dcu
Copy link

@dcu dcu commented Apr 23, 2012

hi,

I ported your project to rack and provided both rack app(FakeS3::App and middleware FakeS3::Servlet).
reading is more than 2x faster
uploading is slightly slower

I switched default server to thin because webrick+rack fails when a PUT/POST request doesn't have body. (it's rack's handler fault)

dcu added 2 commits April 22, 2012 11:33
Signed-off-by: David A. Cuadrado <krawek@gmail.com>
Signed-off-by: David A. Cuadrado <krawek@gmail.com>
@mferrier
Copy link

+1

@jubos
Copy link
Owner

jubos commented Apr 28, 2012

This looks interesting. Does thin require a c compiler to install? I am keen on keeping Fake S3 to only require pure ruby gems to make portability easy. Is the rack webrick issue going to be fixed upstream?

@mferrier
Copy link

mferrier commented May 2, 2012

Removed thin dependency and sent pull request ricodigo#1

@elia
Copy link

elia commented Apr 16, 2015

@jubos anything I can help to make this happen?

@jubos
Copy link
Owner

jubos commented Apr 16, 2015

I think it is a good idea, but just was initially worried about the additional complexity and pulling in another dependency. What is the use case for having FakeS3 as a rack app?

@elia
Copy link

elia commented Apr 16, 2015

I'm using it in conjunction with rack-streaming-proxy to have local s3 with a fallback on production to serve uploaded images in a rails app.

If you're worried about the additional dependency I suggest to just leave it out, but still provide an app conforming to the rack interface.

@elia
Copy link

elia commented May 3, 2015

ping

@pickhardt pickhardt mentioned this pull request Jan 8, 2017
@pickhardt
Copy link
Collaborator

Closing because this was fixed. See #45 (I interpret the thumbs up to mean he acknowledges it worked.)

@pickhardt pickhardt closed this Jan 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants