Do not clear the old values in "Display name publicly as" drop-down o…

…n the user profile screen, append new values there when the user changes any of20747 the name fields, fixes #20747

git-svn-id: http://core.svn.wordpress.org/trunk@20964 1a063a9b-81f0-0310-95a4-ce76da25c4cd

wp-admin/js/user-profile.dev.js

@@ -41,7 +41,7 @@
 
 		if ( select.length ) {
 			$('#first_name, #last_name, #nickname').bind( 'blur.user_profile', function() {
-				var current = select.find('option:selected').attr('id'), dub = [],
+				var dub = [],
 					inputs = {
 						display_nickname  : $('#nickname').val() || '',
 						display_username  : $('#user_login').val() || '',
@@ -54,7 +54,10 @@
 					inputs['display_lastfirst'] = inputs.display_lastname + ' ' + inputs.display_firstname;
 				}
 
-				$('option', select).remove();
+				$.each( $('option', select), function( i, el ){
+					dub.push( el.value );
+				});
+
 				$.each(inputs, function( id, value ) {
 					if ( ! value )
 						return;
@@ -64,9 +67,7 @@
 					if ( inputs[id].length && $.inArray( val, dub ) == -1 ) {
 						dub.push(val);
 						$('<option />', {
-						  	'id': id,
-							'text': val,
-							'selected': (id == current)
+							'text': val
 						}).appendTo( select );
 					}
 				});

wp-admin/user-edit.php

@@ -319,7 +319,7 @@ function use_ssl_preference($user) {
 
 			foreach ( $public_display as $id => $item ) {
 		?>
-			<option id="<?php echo $id; ?>"<?php selected( $profileuser->display_name, $item ); ?>><?php echo $item; ?></option>
+			<option <?php selected( $profileuser->display_name, $item ); ?>><?php echo $item; ?></option>
 		<?php
 			}
 		?>