Apply a map to consistently convert betwen lowercase and uppercase characters. #1161
+687
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrlanglois
changed the title
jrlanglois
changed the title
…and uppercase characters.
jrlanglois
force-pushed
the
ImproveUppercaseLowercaseConv
branch
from
c75725d
to
e916772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
juce::CharacterFunctions's assortment of case related methods to support a consistent, platform-agnostic, solution to uppercase and lowercase conversions, as well as determining if a particular set of bytes equates to a particular case (ie: is lower or is upper).What's knowingly missing/would be a nice to have is a unit test to go through the combinations.
Context: https://forum.juce.com/t/br-string-touppercase-is-wrong/52353