Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Page #7

Closed
ron-popov opened this issue Oct 6, 2017 · 5 comments
Closed

Settings Page #7

ron-popov opened this issue Oct 6, 2017 · 5 comments

Comments

@ron-popov
Copy link
Contributor

A settings page that will contain all of the ide's settings (vim mode toggle, theme selection box, etc ...)

@hermanzdosilovic
Copy link
Member

@ron-popov great idea! I think we should wait for these features to be implemented and then you can start working on it.

Instead of settings page, what do you think about placing a toolbar below navbar?

@ron-popov
Copy link
Contributor Author

I think it will make the page look more crowded , i prefer just placing the button on the current navbar and then moving them to the settings page

@hermanzdosilovic
Copy link
Member

I agree, it would look more crowded. I think the most appropriate solution would be to use modals and not special settings page.

@ron-popov
Copy link
Contributor Author

I will work on this feature.

@hermanzdosilovic
Copy link
Member

@ron-popov great! But make sure you have latest master without merge commits. In the last PR i had to rebase your commits 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants