Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/stdin expected output from url #306

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gkapatia
Copy link

No description provided.

Copy link
Member

@hermanzdosilovic hermanzdosilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gkapatia,

Thank you for your contribution.

Unfortunately, the implementation of this feature does not satisfy the security standards that we are trying to keep in Judge0.

The biggest security problem with this implementation is that it does not limit the size of the downloaded content.

The second problem is that for an URL that returns a status code that is not 200, this code will throw an exception that is not cached anywhere.

I am sorry, but I cannot merge this until these problems are resolved.

Thank you.

Best regards,
Herman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants