Suppress deprecated warning by Object#=~ since ruby 2.6 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not well-versed in this code to be honest. Does this variant work as well? case elem
when Class
…
when /…/
…
endThat would read better to me. |
In `Temple::Mixins::GrammerDSL::Value#Rule`, call `=~` method to `Class` class then that causes a warning message. This behavior introduced from ruby 2.6 with `-W` option. (And ruby 2.7 always show a warning message) - https://bugs.ruby-lang.org/issues/15231 - ruby/ruby@ebff9dc10 Therefore use case-when-else clause to avoid warning.
unasuke
force-pushed
the
deprecate_warning_on_ruby_2_7
branch
from
79f41cd
to
693641f
Compare
|
@judofyr It seems better than my patch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Temple::Mixins::GrammerDSL::Value#Rule, call=~method toClassclass then that causes a warning message.This behavior introduced from ruby 2.6 with
-Woption.(And ruby 2.7 always show a warning message)
https://bugs.ruby-lang.org/issues/15231
ruby/ruby@ebff9dc10
Therefore if "elem" isClassclass, skip calling=~method.Therefore use case-when-else clause to avoid warning.