Fix: Don't include "enabled" metadata with adapters (#193)

This data can change depending on whether the reporter process is running on a "redundant instance", so it's misleading to report it as metadata.
judoscale · Jan 25, 2024 · ff6a560 · ff6a560
1 parent d6ae321
commit ff6a560
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/judoscale-ruby/lib/judoscale-ruby.rb b/judoscale-ruby/lib/judoscale-ruby.rb
@@ -21,17 +21,8 @@ class << self
   end
 
   class Adapter < Struct.new(:identifier, :adapter_info, :metrics_collector)
-    attr_accessor :enabled
-
-    def initialize(identifier, adapter_info, metrics_collector)
-      super
-      self.enabled = false
-    end
-
     def as_json
-      {
-        identifier => adapter_info.merge(enabled: enabled)
-      }
+      {identifier => adapter_info}
     end
   end
 

diff --git a/judoscale-ruby/lib/judoscale/reporter.rb b/judoscale-ruby/lib/judoscale/reporter.rb
@@ -25,9 +25,7 @@ def start!(config, adapters)
       end
 
       enabled_adapters, skipped_adapters = adapters.partition { |adapter|
-        if adapter.metrics_collector&.collect?(config)
-          adapter.enabled = true
-        end
+        adapter.metrics_collector&.collect?(config)
       }
       metrics_collectors_classes = enabled_adapters.map(&:metrics_collector)
       adapters_msg = enabled_adapters.map(&:identifier).concat(