Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async #98

Open
phillijw opened this issue Sep 20, 2019 · 1 comment
Open

Support async #98

phillijw opened this issue Sep 20, 2019 · 1 comment
Assignees

Comments

@phillijw
Copy link

The handler interface does not support async implementations. Either add a new async method implementation or replace existing one to return a Task.

Add async wherever else it makes sense as well.

@judwhite judwhite self-assigned this Sep 20, 2019
@Lercher
Copy link

Lercher commented Apr 8, 2020

+1 just stumbled into a situation, where I needed to call async/await code from the HandleMessage callback. It turns out that just creating a Task via calling an async method seems to work in a console app, however I’m not at all sure that this is the correct sync/async transition. Does the code need to wait for completion? What about exceptions? SynchronisationContext? Does it drain the queue and re-queue all messages in the ThreadPool queue? Does it deadlock itself?

Yes, I guess there is need for either a comprehensive example or even better an async compatible message handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants