Update rubocop

.rubocop.yml

@@ -34,3 +34,10 @@ Style/AsciiComments:
 
 CyclomaticComplexity:
   Max: 10
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/SymbolProc:
+  Exclude:
+    - 'lib/kintone/query.rb'

Guardfile

@@ -1,10 +1,10 @@
-guard :rspec, all_after_pass: false, all_on_start: false, cmd: 'bundle exec rspec' do
+guard :rspec, all_after_pass: false, all_on_start: false, cmd: 'rspec' do
   watch(%r{spec/.+_spec\.rb$})
   watch(%r{lib/(.+)\.rb$}) {|m| "spec/#{m[1]}_spec.rb"}
   watch(%r{lib/(.+)/.+\.rb$}) {|m| "spec/#{m[1]}_spec.rb"}
 end
 
-guard :rubocop, all_on_start: false, cmd: 'bundle exec rubocop' do
+guard :rubocop, all_on_start: false, cmd: 'rubocop' do
   watch(%r{.+\.rb$})
   watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
 end

kintone.gemspec

@@ -1,5 +1,4 @@
 # coding: utf-8
-# rubocop:disable Style/RegexpLiteral
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'kintone/version'
@@ -25,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.5'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '~> 3.0.0'
-  spec.add_development_dependency 'rubocop', '~> 0.24.1'
+  spec.add_development_dependency 'rubocop', '~> 0.44.1'
   spec.add_development_dependency 'webmock', '~> 1.18'
   spec.add_development_dependency 'rspec-parameterized', '~> 0.1.2'
   spec.add_development_dependency 'coveralls'

lib/kintone/api.rb

@@ -7,8 +7,8 @@
 require 'kintone/query'
 
 class Kintone::Api
-  BASE_PATH = '/k/v1/'
-  COMMAND = '%s.json'
+  BASE_PATH = '/k/v1/'.freeze
+  COMMAND = '%s.json'.freeze
   ACCESSIBLE_COMMAND = [
     :record,
     :records,
@@ -92,9 +92,7 @@ def post_file(url, path, content_type, original_filename)
       @connection.post do |request|
         request.url url
         request.headers['Content-Type'] = 'multipart/form-data'
-        request.body = { file: Faraday::UploadIO.new(
-          path, content_type, original_filename,
-          'Content-Disposition' => 'form-data') }
+        request.body = { file: Faraday::UploadIO.new(path, content_type, original_filename) }
       end
     response.body['fileKey']
   end
@@ -103,10 +101,14 @@ def method_missing(name, *args)
     if ACCESSIBLE_COMMAND.include?(name)
       CommandAccessor.send(name, self)
     else
-      super(name, *args)
+      super
     end
   end
 
+  def respond_to_missing?(name, *args)
+    ACCESSIBLE_COMMAND.include?(name) || super
+  end
+
   class CommandAccessor
     extend Kintone::Command::Accessor
   end

lib/kintone/api/guest.rb

@@ -6,7 +6,7 @@ class Kintone::Api
   class Guest
     extend Forwardable
 
-    GUEST_PATH = '/k/guest/%s/v1/'
+    GUEST_PATH = '/k/guest/%s/v1/'.freeze
     ACCESSIBLE_COMMAND = [
       :record,
       :records,
@@ -41,10 +41,14 @@ def method_missing(name, *args)
       if ACCESSIBLE_COMMAND.include?(name)
         CommandAccessor.send(name, self)
       else
-        super(name, *args)
+        super
       end
     end
 
+    def respond_to_missing?(name, *args)
+      ACCESSIBLE_COMMAND.include?(name) || super
+    end
+
     class CommandAccessor
       extend Kintone::Command::Accessor
     end

lib/kintone/command/accessor.rb

@@ -99,6 +99,6 @@ def space_guests(api)
       SpaceGuests.new(api)
     end
 
-    alias_method :bulk, :bulk_request
+    alias bulk bulk_request
   end
 end

lib/kintone/command/guests.rb

@@ -13,5 +13,5 @@ def delete(guests)
     @api.delete(@url, guests: guests)
   end
 
-  alias_method :create, :register
+  alias create register
 end

lib/kintone/command/record.rb

@@ -19,5 +19,5 @@ def update(app, id, record, revision: nil)
     @api.put(@url, body)
   end
 
-  alias_method :create, :register
+  alias create register
 end

lib/kintone/command/records.rb

@@ -26,5 +26,5 @@ def delete(app, ids, revisions: nil)
     @api.delete(@url, params)
   end
 
-  alias_method :create, :register
+  alias create register
 end

lib/kintone/query.rb

@@ -68,7 +68,7 @@ def inspect
     to_s
   end
 
-  alias_method :f, :field
+  alias f field
 
   private
 

lib/kintone/version.rb

@@ -1,3 +1,3 @@
 module Kintone
-  VERSION = '0.1.4'
+  VERSION = '0.1.4'.freeze
 end

spec/kintone/api/guest_spec.rb

@@ -25,8 +25,11 @@
           headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
           query: params
         )
-        .to_return(body: "{\"abc\":\"def\"}", status: 200,
-                   headers: { 'Content-type' => 'application/json' })
+        .to_return(
+          body: '{"abc":"def"}',
+          status: 200,
+          headers: { 'Content-type' => 'application/json' }
+        )
     end
 
     subject { target.get(path, params) }
@@ -45,10 +48,13 @@
       )
         .with(
           headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
-          body: "{\"p1\":\"abc\",\"p2\":\"def\"}"
+          body: '{"p1":"abc","p2":"def"}'
+        )
+        .to_return(
+          body: '{"abc":"def"}',
+          status: 200,
+          headers: { 'Content-type' => 'application/json' }
         )
-        .to_return(body: "{\"abc\":\"def\"}", status: 200,
-                   headers: { 'Content-type' => 'application/json' })
     end
 
     subject { target.post(path, body) }
@@ -67,10 +73,13 @@
       )
         .with(
           headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' },
-          body: "{\"p1\":\"abc\",\"p2\":\"def\"}"
+          body: '{"p1":"abc","p2":"def"}'
+        )
+        .to_return(
+          body: '{"abc":"def"}',
+          status: 200,
+          headers: { 'Content-type' => 'application/json' }
         )
-        .to_return(body: "{\"abc\":\"def\"}", status: 200,
-                   headers: { 'Content-type' => 'application/json' })
     end
 
     subject { target.put(path, body) }
@@ -91,8 +100,11 @@
           body: { 'p1' => 'abc', 'p2' => 'def' }.to_json,
           headers: { 'X-Cybozu-Authorization' => 'QWRtaW5pc3RyYXRvcjpjeWJvenU=' }
         )
-        .to_return(body: "{\"abc\":\"def\"}", status: 200,
-                   headers: { 'Content-type' => 'application/json' })
+        .to_return(
+          body: '{"abc":"def"}',
+          status: 200,
+          headers: { 'Content-type' => 'application/json' }
+        )
     end
 
     subject { target.delete(path, params) }