✨ webhook notifications #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdwolfe
reviewed
Sep 12, 2023
camply/notifications/webhook.py
Outdated
| ---------- | ||
| campsites: List[AvailableCampsite] | ||
| """ | ||
| self.send_message(message=campsites) |
There was a problem hiding this comment.
I recommend adding an envelope around campsites, which allows for sibling data to be added in the future without making a backward incompatible change to the model.
So this:
self.send_message(message=campsites)could be
self.send_message(message={"campsites": campsites})which lets you hang non-campsite metadata or others if needed
self.send_message(message={"campsites": campsites, "notification_id": "blah"}).. and the client need not change anything.
There was a problem hiding this comment.
Yeah, that's a good idea. I addressed this and added a timestamp field as well.
zdwolfe
suggested changes
Sep 12, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 13, 2023
# [v0.30.0](v0.29.0...v0.30.0) (2023-09-13) ## ✨ New Features - [`3ab5333`](3ab5333) webhook notifications (#296) (Issues: [`#296`](#296)) [skip ci]
|
🎉 This PR is included in version 0.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send notifications to a webhook endpoint
Resolves #295