✨ install with pip [former]

[juftin]

Changes

• New installer class
  • Changes default behavior to run pip install -r lockfile.txt instead of pip-sync lockfile.txt
    • Makes this a configurable option, pip-compile-installer
  • Only forces project reinstall when using pip-sync option
  • Deletes lockfile if no dependencies with both pip and pip-sync options

Yet another alternative to #30

Closes #29

[juftin]

There is a safe_activation context needed here

Suggested change

	if not self.lockfile_up_to_date:
	self.install_pip_tools()
	if self.piptools_lock_file.exists():
	_ = self.piptools_lock.compare_python_versions(
	verbose=self.config.get("pip-compile-verbose", None)
	)
	self.pip_compile_cli()
	if not self.lockfile_up_to_date:
	with self.safe_activation():
	self.install_pip_tools()
	if self.piptools_lock_file.exists():
	_ = self.piptools_lock.compare_python_versions(
	verbose=self.config.get("pip-compile-verbose", None)
	)
	self.pip_compile_cli()

[juftin]

See #34 (comment)

There is a scenario where the lockfile doesn't exist and install_dev_mode invokes _full_install without run_pip_compile ever being called

Suggested change

	with self.environment.safe_activation():
	self.install_dependencies()
	with self.environment.safe_activation():
	self.environment.run_pip_compile()
	self.install_dependencies()

[oprypin]

Ah just commit these! Oh I see, you can't 😅
Maybe needs yet another new PR as per the other comment. Or let me know, I can just commit this

[juftin]

I would expect an additional mention of you as sub-author here in the GitHub UI in addition to the squash commit message. Maybe because I opened the PR?

[oprypin]

It might be messing up because the commit is in my repo 🤔

Regarding the co-authored-by - you can always add that string manually
But at this point I'm wondering if it's messing up and will not credit you as the author, only the commiter.
That being the reason maybe it thinks co-authored is redundant

You should perhaps just push the same branch to your repo (+ a new PR)

git checkout -b branchname
git fetch origin 00f5b13015c1b36318f53377a8a603cc2fb9c5a9
git reset --hard 00f5b13015c1b36318f53377a8a603cc2fb9c5a9
git push origin branchname

[juftin]

#36 now 🤷