Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 constraint venv state #68

Merged
merged 2 commits into from
Feb 1, 2024
Merged

🐛 constraint venv state #68

merged 2 commits into from
Feb 1, 2024

Conversation

juftin
Copy link
Owner

@juftin juftin commented Jan 31, 2024

This PR fixes an issue where a constraint environment is created but doesn't contain the right dependencies. This was also happening inadvertently and breaking the hatch env prune functionality.

A more ideal version of this could be done with pypa/hatch#1228.

Closes #63
Closes #65

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18a8a96) 93.16% compared to head (500feb5) 95.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   93.16%   95.56%   +2.40%     
==========================================
  Files          16       16              
  Lines         819      857      +38     
  Branches      130      139       +9     
==========================================
+ Hits          763      819      +56     
+ Misses         35       24      -11     
+ Partials       21       14       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juftin juftin merged commit 655b16c into main Feb 1, 2024
12 checks passed
@juftin juftin deleted the fix/constraint_venv_state branch February 1, 2024 03:10
@juftin
Copy link
Owner Author

juftin commented Feb 1, 2024

🎉 This PR is included in version 1.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@juftin juftin added the released label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant