Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.disconnect() breaks additional observe calls #104

Closed
JMStewart opened this issue May 20, 2020 · 1 comment
Closed

.disconnect() breaks additional observe calls #104

JMStewart opened this issue May 20, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@JMStewart
Copy link

Describe the bug
When I call .disconnect() on an observer, it prevents the observer from being used again. It won't throw any errors, but the resize events will not fire for anything added after calling disconnect.
The native implementation just clears the current list of observe targets, but then you can start observing again with the same instance. So I can use disconnect to clear all current observers, and then add new ones.

@TremayneChrist TremayneChrist added the bug Something isn't working label May 21, 2020
@TremayneChrist
Copy link
Member

Hi @JMStewart,

I seem to have originally overlooked the details of the disconnect API. Unfortunately it's not a super simple fix, so it may take a bit of time testing before I can publish a release. Hopefully I can get it done this week though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants