Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disconnect then observe #106

Merged
merged 9 commits into from
May 31, 2020
Merged

fix: disconnect then observe #106

merged 9 commits into from
May 31, 2020

Conversation

TremayneChrist
Copy link
Member

Fixes an issue (#104) where calling disconnect on an observer would prevent you from observing elements again.

const ro = new ResizeObserver();
ro.observe(document.body);
ro.disconnect()
ro.observe(document.body);

@TremayneChrist TremayneChrist merged commit d9cf293 into master May 31, 2020
@TremayneChrist TremayneChrist deleted the fix-disconnect-observe branch May 31, 2020 15:05
This was referenced May 31, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TremayneChrist