Total hits and histogram control touchups #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix double EuiSelectable focus ring styles - Fix issue where toolbar buttons get cut off on smaller screen sizes - Add tooltips to toolbar buttons so users can see the full labels when truncated - Tweak toolbar button menu designs to more closely match mockups (full-width menu items, compressed search bar, show all time interval menu items without scrolling) - Add middle truncation to toolbar button menus for long values, and update search bar placeholder to "Search" to match mockups - Autofocus on toolbar button menu selectables when popover is opened - Update toolbar button menu "no results" display to put message and search term on one line - Remove extra 2 pixels below Lens suggestion selector caused by `display: inline-block`, and update tooltip delay to "long" to match the toolbar button tooltips
4 tasks
|
Thanks, Davis! |
jughosta
merged commit 3cc96c3
into
jughosta:168825-move-total-hits
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several UX touchups to the original PR:
Fix double
EuiSelectablefocus ring styles:Fix issue where toolbar buttons get cut off on smaller screen sizes (also happened in mobile view):
Add tooltips to toolbar buttons so users can see the full labels when truncated:
Tweak toolbar button menu designs to more closely match mockups (full-width menu items, compressed search bar, show all time interval menu items without scrolling). Add middle truncation to toolbar button menus for long values, and update search bar placeholder to "Search" to match mockups. Autofocus on toolbar button menu selectables when popover is opened (improves a11y for keyboard users):
Update toolbar button menu "no results" display to put message and search term on one line (the
<strong>tag was usingdisplay: blockwhen not wrapped in a<p>tag):Remove extra 2 pixels below Lens suggestion selector caused by
display: inline-block, and update tooltip delay to "long" to match the toolbar button tooltips.