Refactor Type to TypeTree
#408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor custom `Type` parsing logic to `TypeTree` in parameters, headers, responses and request bodies. The original parsing logic in `Type` was fairly limited in capabilities and superfluous in itself. Migrating to `TypeTree` which is is already used everywhere else comes with benefits like single source of parsing type trees and support for vast set of different kind of types that where not supported with the custom type parsing. `TypeTree` allows users to use almost any Rust types instead of those few predefined ones. The change is invisible to the users and also `TypeTree` fixes a bug in incorrect default content type for primitive type of arrays.
juhaku
force-pushed
the
refactor-custom-type-type-tree
branch
from
5c31fb6
to
8bf1ed8
Compare
This was referenced Dec 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor custom
Typeparsing logic toTypeTreein parameters, headers, responses and request bodies. The original parsing logic inTypewas fairly limited in capabilities and superfluous in itself.Migrating to
TypeTreewhich is is already used everywhere else comes with benefits like single source of parsing type trees and support for vast set of different kind of types that where not supported with the custom type parsing.TypeTreeallows users to use almost any Rust types instead of those few predefined ones. The change is invisible to the users and alsoTypeTreefixes a bug in incorrect default content type for primitive type of arrays.Fixes #335, Fixes #217, Fixes #194, Fixes #164