Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axum 0.7 bindings #807

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Axum 0.7 bindings #807

merged 8 commits into from
Nov 28, 2023

Conversation

Libbum
Copy link
Contributor

@Libbum Libbum commented Nov 27, 2023

Hi! First contribution to this repo, so may have missed some things.

Axum 0.7 just got released which has some breaking changes to bring everything up to date with hyper 1.0.

The main consequence for utoipa is the removal of hyper's HttpBody from Router.

Resolves #808

@juhaku
Copy link
Owner

juhaku commented Nov 27, 2023

With this update, there are examples with the axum 0.6 that should be also upgraded, but that can be another PR.

@Libbum
Copy link
Contributor Author

Libbum commented Nov 27, 2023

Ah, yes. If you mean just the examples/todo-axum demo, I can do that tomorrow morning.

@juhaku
Copy link
Owner

juhaku commented Nov 27, 2023

Ah, yes. If you mean just the examples/todo-axum demo, I can do that tomorrow morning.

Yes, that one indeed. 🙂

Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing actually, the REAMDE.md, should be changed as well for utoipa-swagger-ui and utoipa-redoc and utoipa-rapidoc with the same changes as the src/lib.rs by removing the B attribute. Also the latest minimum version should be updated to 0.7 in these READMEs.

@Libbum
Copy link
Contributor Author

Libbum commented Nov 28, 2023

Sweet, that should all be done now 😄

Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 🎉

@juhaku juhaku merged commit 93dfaf1 into juhaku:master Nov 28, 2023
5 checks passed
@Libbum Libbum deleted the axum0.7 branch November 28, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SwaggerUI dont work with axum 0.7.x
2 participants