Refactor ReDoc to take Cow<'static, str> instead of borrowed str
#869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the fields match the existing example in `utoipa_swagger_ui::SwaggerUi` (field `path`). Fixes juhaku#805
That is true, but the changes are low, but sure when the release is done this is going to be a major release. 🙂 Just to be explisit about possibility of stuff breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same thing as #867, except I modified
ReDocthis time.Breaking changes
Just like #867: I think the removal of the two lifetime parameters on
ReDoccan break some code (e.g. when implementing custom traits forReDoc). As far as the method parameters are concerned, I don't think there are any breaking changes due to theInto<Cow<'static, str>generic.