-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add koji tag location support #4
Conversation
This change enables comparing koji tag using a new syntax: `tag`@`kojihub`
Okay, cool, I just noticed this and will try to review this tomorrow. I have pondered before about syntax for interesting new sources, eg ssh (but wondering if abc@xyz may be too generic, though not sure what would be better: maybe using (pseudo)-uri's like koji://tag@hub perhaps?) |
Oh right, I forgot to mention I wasn't a big fan of the The issue with using a Though I can't think of a better solution. Let me do the change. |
Hmm yea, good point - never seen url in uri before... Guess it is not worse than xml embedded in xml, lol (Me looks into Koji rpc' eyes... ;o) |
Another solution would be a simpler |
Basically looks good to me: though I haven't tried it.
How about Or possibly |
This change also adds the CMD number
Removing the koji http scheme can be an issue too when the service is only http or https. I think that's quite a special case, and |
Thanks, looking forward to play with this later 👍 |
This change enables comparing koji tag using a new syntax:
tag
@kojihub