Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSQL Challenges #328

Closed
J12934 opened this issue Jun 12, 2017 · 9 comments
Closed

NoSQL Challenges #328

J12934 opened this issue Jun 12, 2017 · 9 comments

Comments

@J12934
Copy link
Member

J12934 commented Jun 12, 2017

Hi Guys,
me and a few colleges of mine have wanted to use the JuiceShop to demonstrate NoSQL Injection Attacks. To Do this we have implemented a MongoDB Integration to JuiceShop using a prebuild MongoDB loaded via npm.
The MongoDB is used to store comments for the products. There are 2 challenges regarding NoSQL Injections at the moment.

This was implemented a few Months ago there were some problems with the libraries that should be solved by now.
During OWASP Summit i'd like to update these integration. I dont know if it will be done by the end of it / if it is in a state to get merged by the end of it.

The branch with the current features can be found here:
Feature Branch

I'm always open for feedback on the idea and the features.
Have a good time at the Summit

@bkimminich
Copy link
Member

I remember that one... somehow slipped through... It requires a separate DB running, so probably not possible the easy way with single Dockerfile, right? You built in a way where the additional challenges are only available if you find a running NoSQL DB at an expected URL, right?

@J12934
Copy link
Member Author

J12934 commented Jun 12, 2017

The MongoDB now runs in the same Container as the the Applications.
The Process get started by the Node Server itself.

The challenge disabling is still in the current implementation, but more a relict of the times where the MongoDB was external. Probably not even really needed when the Database always gets installed with the Application.

@bkimminich
Copy link
Member

Oh, this is awesome news! No docker compose needed? 🎉

@bkimminich bkimminich changed the title NoSQL Challages NoSQL Challenges Jun 12, 2017
@J12934
Copy link
Member Author

J12934 commented Jun 12, 2017

Yup

@bkimminich
Copy link
Member

It'd be great if you could rebase your changes to develop branch. That's easiest to merge them, when it's ready! Let me know if you need any assistance!

@J12934
Copy link
Member Author

J12934 commented Jun 13, 2017

Ok i will try that.
And yes i might need some assistance on that, never did any rebasing before 😅

@bkimminich
Copy link
Member

Looks there are a few conflicts occuring between your branch and the main repo (no matter if develop or master). It might be easier in the end if you fork freshly and re-apply your changes/enhancements. Sorry for that, but merging might probably be even less fun.

@J12934
Copy link
Member Author

J12934 commented Jun 15, 2017

Ok no problem I will do so.
I haven't had any time to work on it during the week, i gonna look into updating the code during the weekend

@lock
Copy link

lock bot commented Nov 4, 2019

This thread has been automatically locked because it has not had recent activity after it was closed. 🔒 Please open a new issue for regressions or related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants