Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure CTF key via enviroment variable #346

Closed
achimgrimm opened this issue Jun 16, 2017 · 4 comments
Closed

Configure CTF key via enviroment variable #346

achimgrimm opened this issue Jun 16, 2017 · 4 comments

Comments

@achimgrimm
Copy link
Contributor

Currently the CTF key will always be used from the key file ctf.key.
While running the shop as a docker container, the file can not be changed.

So there should be the option to set the key via a enviroment variable. This can be passed into the docker container on runtime.

@bkimminich
Copy link
Member

Actually you can mount the file to a file outside the container. See https://docs.docker.com/engine/tutorials/dockervolumes/#mount-a-host-file-as-a-data-volume. Please try that, probably we don't need any implementation for this issue then.

@bkimminich
Copy link
Member

If it works like that it should go into the CTF and customization documentation.

@achimgrimm
Copy link
Contributor Author

I think this was my suggested solution before:
docker run -d -p 3000:3000 -e "NODE_ENV=ctf" -v /tmp/mySecretKey.key:/juice-shop/ctf.key --name juice-shop bkimminich/juice-shop

I already complted the pull request. So please feel free to merge or decline the PR.

@lock
Copy link

lock bot commented Nov 4, 2019

This thread has been automatically locked because it has not had recent activity after it was closed. 🔒 Please open a new issue for regressions or related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants